Re: Add json_typeof() and json_is_*() functions.

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Merlin Moncure <mmoncure(at)gmail(dot)com>
Cc: Andrew Tipton <andrew(at)kiwidrew(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Add json_typeof() and json_is_*() functions.
Date: 2013-08-02 14:56:58
Message-ID: 20130802145657.GJ5669@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Merlin Moncure escribió:
> On Fri, Aug 2, 2013 at 7:22 AM, Andrew Tipton <andrew(at)kiwidrew(dot)com> wrote:
> > On Fri, Aug 2, 2013 at 8:12 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >>
> >> +1, but I'm wondering why we need anything more than just
> >> json_typeof(). Doesn't that pretty much cover it?
> >
> > I agree with Merlin that json_is_object() is superfluous, since it can just
> > be replaced with json_typeof() = 'object'. Likewise for json_is_array().
> > But without json_is_scalar(), the choice is one of these two forms:
> > json_typeof() NOT IN ('object', 'array')
> > json_typeof() IN ('string', 'number', 'boolean', 'null')
> >
> > And it protects the user against forgetting about, say, the 'null' typeof()
> > when constructing their check expression.
>
> right: I was thinking also that if/when json were ever to get new
> types, you'd appreciate that function.

That was what I thought as well upon seen the code.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2013-08-02 14:59:05 Re: Immediate shutdown causes the assertion failure in 9.4dev
Previous Message Stephen Frost 2013-08-02 14:54:42 Re: Re: ALTER SYSTEM SET command to change postgresql.conf parameters (RE: Proposal for Allow postgresql.conf values to be changed via SQL [review])