| From: | Shubham Khanna <khannashubham1197(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, christophe(dot)courtois(at)dalibo(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Subject: | Re: pg_createsubscriber: publication-name and subscription-name options do not exist |
| Date: | 2024-12-03 05:11:36 |
| Message-ID: | CAHv8RjJ8EDnphOBQP9+DK7_SebQvabpgzjW2VfVQNh8-=hv9QA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Tue, Dec 3, 2024 at 10:25 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi Shubham,
>
> The patch v5-0001 looks mostly OK to me (visual inspection only).
>
> But, I did notice one other improvement you could make in passing.
>
> 1.
> - TABLES</literal></link>. If <option>publication-name</option> option is
> - not specified, it has the following name pattern:
> + TABLES</literal></link>. If <option>--publication</option> is not
> + specified, it has the following name pattern:
>
> Instead of saying "it has the following name pattern:", IMO it is better to say:
> "the publication has the following name pattern:".
>
> That would make it consistent with the similar sentences which are saying:
> "... the replication slot has the following name pattern:
> "... the subscription has the following name pattern:"
>
I have added the suggested change. The attached Patch contains the
required changes.
Thanks and regards,
Shubham Khanna.
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-DOCS-Fix.patch | application/octet-stream | 2.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-12-03 05:58:04 | Re: pg_createsubscriber: publication-name and subscription-name options do not exist |
| Previous Message | Peter Smith | 2024-12-03 04:54:48 | Re: pg_createsubscriber: publication-name and subscription-name options do not exist |