| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CREATE SUBSCRIPTION - add missing test case |
| Date: | 2024-08-20 02:51:08 |
| Message-ID: | CAHut+Puxkif7sg-Jah9Qw8RNKL3zb7v_gqMmOudvo57PG_hUTQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 16, 2024 at 2:15 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>
Thanks for the review.
>
> I agree currently there is no test to hit this code. I'm not sure if
> this is the correct location for the test, should it be included in
> the 008_diff_schema.pl file?
Yes, that is a better home for this test. Done as suggested in
attached patch v2.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Add-missing-test-case.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Smith | 2024-08-20 03:05:33 | Re: PG docs - Sequence CYCLE clause |
| Previous Message | Tender Wang | 2024-08-20 02:45:47 | Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails |