Re: CREATE SUBSCRIPTION - add missing test case

From: vignesh C <vignesh21(at)gmail(dot)com>
To: Peter Smith <smithpb2250(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: CREATE SUBSCRIPTION - add missing test case
Date: 2024-08-20 12:19:54
Message-ID: CALDaNm1aPFHe1DA-BJGb+7YqFCMRYHTOf2xSXLKCEThTSDLj1Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, 20 Aug 2024 at 08:21, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Fri, Aug 16, 2024 at 2:15 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> >
>
> Thanks for the review.
>
> >
> > I agree currently there is no test to hit this code. I'm not sure if
> > this is the correct location for the test, should it be included in
> > the 008_diff_schema.pl file?
>
> Yes, that is a better home for this test. Done as suggested in
> attached patch v2.

Thanks, this looks good to me.

Regards,
Vignesh

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-08-20 12:24:24 Re: Fix memory counter update in reorderbuffer
Previous Message vignesh C 2024-08-20 12:19:25 Re: long-standing data loss bug in initial sync of logical replication