Re: GUC names in messages

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Peter Eisentraut <peter(at)eisentraut(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: GUC names in messages
Date: 2024-09-03 23:17:15
Message-ID: CAHut+PsZpDLcYOG_aZUkBkg1fnO4DFKORTcdgn5EBy954xTaDw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 3, 2024 at 4:35 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Sep 03, 2024 at 12:00:19PM +1000, Peter Smith wrote:
> > Here is the rebased patch set v10*. Everything is the same as before
> > except now there are only 7 patches instead of 8. The previous v9-0001
> > ("bool") patch no longer exists because those changes are now already
> > present in HEAD.
> >
> > I hope these might be pushed soon to avoid further rebasing.
>
> 0001~0004 could just be merged, they're the same thing, for different
> GUC types. The consensus mentioned in 17974ec25946 makes that clear.
>
> 0007 is a good thing for translators, indeed.. I'll see about doing
> something here, at least.
> --
> Michael

Hi Michael, thanks for your interest.

I have merged the patches 0001-0004 as suggested. Please see v11 attachments.

======
Kind Regards,
Peter Smith.
Fujitsu Australia

Attachment Content-Type Size
v11-0001-Add-quotes-for-GUCs.patch application/octet-stream 11.7 KB
v11-0003-GUC-names-fix-case-datestyle.patch application/octet-stream 11.2 KB
v11-0004-GUC-names-make-common-translatable-messages.patch application/octet-stream 18.5 KB
v11-0002-GUC-names-fix-case-intervalstyle.patch application/octet-stream 1.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ilya Gladyshev 2024-09-03 23:28:23 Re: optimizing pg_upgrade's once-in-each-database steps
Previous Message Jacob Champion 2024-09-03 21:47:57 Re: [PATCH] pg_stat_activity: make slow/hanging authentication more visible