| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Subject: | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-04-09 23:52:14 |
| Message-ID: | CAHut+PvNNob_3cMuwTLqAeqNZSOEqoqaFwv0QMaBS433W157xQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 9, 2025 at 8:08 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Apr 9, 2025 at 7:48 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
> >
> > I was looking at the recent push for the pg_createsubscription "--all"
> > option [1], because I was absent for several weeks prior.
> >
> > I found some minor non-functional issues as follows:
> >
> > ======
> > doc/src/sgml/ref/pg_createsubscriber.sgml
> > ~
> >
> > 1c.
> > I didn't think the sentence quite belongs here because it isn't
> > describing anything about the --all option. Instead, it is describing
> > how the source server connection is made.
> >
>
> This sentence describes how we connect when --all option is used. For
> other cases, see the description in the -d option. So, this change is
> not required. If you agree, then you can combine the other two
> patches, and we can proceed with those.
>
OK. Here is a single patch which combines previous patches 0001 and 0003.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v20250410-0001-Fix-DOCS-and-code-comment-for-option-all.patch | application/octet-stream | 2.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2025-04-09 23:54:21 | Re: Large expressions in indexes can't be stored (non-TOASTable) |
| Previous Message | Jelte Fennema-Nio | 2025-04-09 23:42:28 | Re: [PoC] Federated Authn/z with OAUTHBEARER |