| From: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>, Ajin Cherian <itsajin(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com> |
| Subject: | Re: Enhance 'pg_createsubscriber' to retrieve databases automatically when no database is provided. |
| Date: | 2025-04-09 10:07:56 |
| Message-ID: | CAA4eK1JsyK0X+t4v1H_0J+SOa1aMeHRYuoENEvVFfKb5FSXHog@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Apr 9, 2025 at 7:48 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> I was looking at the recent push for the pg_createsubscription "--all"
> option [1], because I was absent for several weeks prior.
>
> I found some minor non-functional issues as follows:
>
> ======
> doc/src/sgml/ref/pg_createsubscriber.sgml
> ~
>
> 1c.
> I didn't think the sentence quite belongs here because it isn't
> describing anything about the --all option. Instead, it is describing
> how the source server connection is made.
>
This sentence describes how we connect when --all option is used. For
other cases, see the description in the -d option. So, this change is
not required. If you agree, then you can combine the other two
patches, and we can proceed with those.
--
With Regards,
Amit Kapila.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-04-09 10:24:00 | Re: tab complete for COPY populated materialized view TO |
| Previous Message | Heikki Linnakangas | 2025-04-09 10:03:24 | PostgreSQL 18 Release Management Team & Feature Freeze |