| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | Vik Fearing <vik(at)postgresfriends(dot)org> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: boolin comment not moved when code was refactored |
| Date: | 2023-10-19 05:17:43 |
| Message-ID: | CAHut+Pv8A_9QgwNZgQuB3gR6my7u7aiUXPHBUkntPoJS7L+3ow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Oct 19, 2023 at 3:26 PM Vik Fearing <vik(at)postgresfriends(dot)org> wrote:
>
> On 10/19/23 06:17, Peter Smith wrote:
> >> In short, maybe the whole comment should just be
> >>
> >> /*
> >> * boolin - input function for type boolean
> >> */
> >>
> > How about "boolin - converts a boolean string value to 1 or 0"
>
>
> Personally, I do not like exposing the implementation of a boolean (it
> is a base type that is not a numeric), so I prefer Tom's suggestion.
OK. Done that way.
PSA v2.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Relocate-or-remove-stale-comments.patch | application/octet-stream | 1.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2023-10-19 05:22:06 | Re: Patch: Improve Boolean Predicate JSON Path Docs |
| Previous Message | Andres Freund | 2023-10-19 04:49:07 | Re: run pgindent on a regular basis / scripted manner |