Re: boolin comment not moved when code was refactored

From: Vik Fearing <vik(at)postgresfriends(dot)org>
To: Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: boolin comment not moved when code was refactored
Date: 2023-10-19 04:26:54
Message-ID: 6198272b-294a-4116-ab85-8472349b76dc@postgresfriends.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10/19/23 06:17, Peter Smith wrote:
>> In short, maybe the whole comment should just be
>>
>> /*
>> * boolin - input function for type boolean
>> */
>>
> How about "boolin - converts a boolean string value to 1 or 0"

Personally, I do not like exposing the implementation of a boolean (it
is a base type that is not a numeric), so I prefer Tom's suggestion.
--
Vik Fearing

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2023-10-19 04:32:38 Re: BRIN minmax multi - incorrect distance for infinite timestamp/date
Previous Message Peter Smith 2023-10-19 04:17:33 Re: boolin comment not moved when code was refactored