Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Robert Sjöblom <robert(dot)sjoblom(at)fortnox(dot)se>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [DOC] Update ALTER SUBSCRIPTION documentation v3
Date: 2023-05-17 01:18:26
Message-ID: CAHut+Pv7pdsr5tv8JocRB91uEEb2yb=sDZzSG9o4TeM1-NTNLA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

+ errhint("Use %s to disassociate the subscription from the slot after
disabling the subscription.",

IMO it looked strange having the word "subscription" 2x in the same sentence.

Maybe you can reword the errhint like:

BEFORE
"Use %s to disassociate the subscription from the slot after disabling
the subscription."

SUGGESTION#1
"Disable the subscription, then use %s to disassociate it from the slot."

SUGGESTION#2
"After disabling the subscription use %s to disassociate it from the slot."

~~~

BTW, it is a bit difficult to follow this thread because the subject
keeps changing.

------
Kind Regards,
Peter Smith.
Fujitsu Australia

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2023-05-17 01:25:04 Re: benchmark results comparing versions 15.2 and 16
Previous Message Ajin Cherian 2023-05-17 01:09:59 Re: running logical replication as the subscription owner