Re: [DOC] Update ALTER SUBSCRIPTION documentation v3

From: Robert Sjöblom <robert(dot)sjoblom(at)fortnox(dot)se>
To:
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [DOC] Update ALTER SUBSCRIPTION documentation v3
Date: 2023-05-16 13:01:52
Message-ID: CAA96TE0teCYk2A6LezGiJawJpyfoA3pTZsT=obMSrh_d7Q3VpA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Den tis 16 maj 2023 kl 01:44 skrev Peter Smith <smithpb2250(at)gmail(dot)com>:
>
> On Mon, May 15, 2023 at 11:36 PM Robert Sjöblom
> <robert(dot)sjoblom(at)fortnox(dot)se> wrote:
> >
> >
> >
> > On 2023-05-05 15:17, Robert Sjöblom wrote:
> > >
> > > Hi,
> > >
> > > We have recently used the PostgreSQL documentation when setting up our
> > > logical replication. We noticed there was a step missing in the
> > > documentation on how to drop a logical replication subscription with a
> > > replication slot attached.
> >
> > Following discussions, please see revised documentation patch.
> >
>
> LGTM.
>
> BTW, in the previous thread, there was also a suggestion from Amit [1]
> to change the errhint in a similar way. There was no reply to Amit's
> idea, so it's not clear whether it's an accidental omission from your
> v2 patch or not.
>
> ------
> [1] https://www.postgresql.org/message-id/CAA4eK1J11phiaoCOmsjNqPZ9BOWyLXYrfgrm5vU2uCFPF2kN1Q%40mail.gmail.com
>
> Kind Regards,
> Peter Smith.
> Fujitsu Australia

Accidental omission by way of mail client, I suppose -- some messages
got flagged as spam and moved to another folder. I went ahead with
Masahiko Sawada's suggestion for the error message; see revised patch.

Best regards,
Robert Sjöblom

--
Innehållet i detta e-postmeddelande är konfidentiellt och avsett endast för
adressaten.Varje spridning, kopiering eller utnyttjande av innehållet är
förbjuden utan tillåtelse av avsändaren. Om detta meddelande av misstag
gått till fel adressat vänligen radera det ursprungliga meddelandet och
underrätta avsändaren via e-post

Attachment Content-Type Size
logical_replication_slot_disable_doc_update_v3.patch application/x-patch 1.8 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2023-05-16 13:10:53 Re: Assert failure of the cross-check for nullingrels
Previous Message Andrew Dunstan 2023-05-16 12:55:20 Re: issue with meson builds on msys2