| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, exclusion(at)gmail(dot)com, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #18558: ALTER PUBLICATION fails with unhelpful error on attempt to use system column |
| Date: | 2024-08-14 04:51:33 |
| Message-ID: | CAHut+Pt0A3-1nqb0WaEsaQU3mtdw_gSGCFDj2CbR=Z_b3BHPsA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Aug 12, 2024 at 5:45 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
...
>
> Here's the patch updated to do the validation inside AlterPublicationTables().
>
Hi David,
I think we've come full circle -- your fix is now pretty much the same
as my v3 patch [1].
The main difference is you have taken the opportunity to tidy some of
the surrounding functions at the same time as making the fix.
Your patch looks good to me.
~~~
publication_add_relation:
nit - variable /Bitmapset *columns;/Bitmapset *attnums;/
nit - comment /validate and translate.../Validate and translate.../
publication_validate_column_list:
nit - consider renaming this function to 'pub_collist_validate' (just
to be more like the existing 'pub_collist_to_bitmapset')
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rainer J.H. Brandt | 2024-08-14 05:45:34 | Re: BUG #18581: psql symbol append_history not found when quitting |
| Previous Message | DBA | 2024-08-14 01:41:50 | Certain options in pg_upgrade don't seem to work. |