Re: Small documentation improvement for ALTER SUBSCRIPTION

From: Peter Smith <smithpb2250(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Small documentation improvement for ALTER SUBSCRIPTION
Date: 2021-08-08 04:50:53
Message-ID: CAHut+PsNUWpd8wUFNCAUKOZ4ay=YDNeAx9+LGs=czKfv4EKQmw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 7, 2021 at 4:33 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Thu, Jul 8, 2021 at 6:31 PM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> >
> > Hi all,
> >
> > When reading the doc of ALTER SUBSCRIPTION I realized that 'refresh
> > options' in the following paragraph is not tagged:
> >
> > ---
> > Additionally, refresh options as described under REFRESH PUBLICATION
> > may be specified, except in the case of DROP PUBLICATION.
> > ---
> >
> > When I read it for the first time, I got confused because we actually
> > have the 'refresh' option and this description in the paragraph of the
> > 'refresh' option. I think we can improve it by changing to
> > '<replaceable>refresh_option</replaceable>'. Thoughts?
> >
>
> I see that one can get confused but how about changing it to
> "Additionally, refresh options as described under <literal>REFRESH
> PUBLICATION</literal> (<replaceable>refresh_option</replaceable>) may
> be specified,.."? I think keeping "refresh options" in the text would
> be good because there could be multiple such options.
>

I feel like it would be better to reword it in some way that avoids
using parentheses because they look like part of the syntax instead of
just part of the sentence.

------
Kind Regards,
Peter Smith.
Fujitsu Australia.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Julien Rouhaud 2021-08-08 05:46:39 Re: elog.c query_id support vs shutdown
Previous Message Andres Freund 2021-08-08 02:24:35 Re: pgsql: pgstat: Bring up pgstat in BaseInit() to fix uninitialized use o