| From: | Peter Smith <smithpb2250(at)gmail(dot)com> |
|---|---|
| To: | vignesh C <vignesh21(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Rajendra Kumar Dangwal <dangwalrajendra888(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, euler(at)eulerto(dot)com |
| Subject: | Re: Pgoutput not capturing the generated columns |
| Date: | 2024-11-06 02:04:15 |
| Message-ID: | CAHut+PsHkZc3GSoocXyCX8vh57AxdYFeMQQifETz9uGoJp1W3g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Vignesh,
Here are my review comments for patch v49-0001.
======
src/backend/catalog/pg_publication.c
1. check_fetch_column_list
+bool
+check_fetch_column_list(Publication *pub, Oid relid, MemoryContext mcxt,
+ Bitmapset **cols)
+{
+ HeapTuple cftuple = NULL;
+ Datum cfdatum = 0;
+ bool found = false;
+
1a.
The 'cftuple' is unconditionally assigned; the default assignment
seems unnecessary.
~
1b.
The 'cfdatum' can be declared in a lower scope (in the if-block).
The 'cfdatum' is unconditionally assigned; the default assignment
seems unnecessary.
======
Kind Regards,
Peter Smith.
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2024-11-06 02:43:22 | Re: doc fail about ALTER TABLE ATTACH re. NO INHERIT |
| Previous Message | Tom Lane | 2024-11-06 01:05:16 | Re: Converting contrib SQL functions to new style |