Re: Call for feedback on pgAdmin4 features

Hello Ashesh,

We're happy to share our modifications. Unfortunately, we're not
knowledgeable in python so we did the best we could.

The problem we had, was pgadmin crashed when it fetched results in a latin
encoding, and it would display nothing.

We modified this method in : web/pgadmin/tools/sqleditor/__init__.py

*METHOD :*

@blueprint.route('/poll/<int:trans_id>', methods=["GET"])

@login_required

def poll(trans_id):

*We added the following code : *

elif status == 'Success' and isinstance(result, list):

for row in result:

for k,v in row.items():

if isinstance(v, str):

row[k] = v.decode('latin9', 'ignore')

The other modification is in : web/pgadmin/utils/driver/psycopg2/__init__.py

*METHOD : *def connect(self, **kwargs):

*We made this modification : *

status = _execute(cur, """

SET DateStyle=ISO;

SET client_min_messages=notice;

SET bytea_output=escape;

SET datestyle = 'ISO,DMY';

SET client_encoding='LATIN9';""")

I Hope this is useful to you.

- Jose

On Sun, Feb 26, 2017 at 9:34 PM, Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com
> wrote:

> Hi jbiskofski,
>
> On Sat, Feb 25, 2017 at 1:45 AM, jbiskofski <jbiskofski(at)gmail(dot)com> wrote:
>
>> We use PGADMIN4 heavily in my place of work. We use it, so tech support
>> can connect to different postgres instances of our customers. We made some
>> modifications ( unfortunately we didnt make them in a configurable way, its
>> all hard-coded )
>>
> We're trying to fix the encoding issue at our end, but - we (Developer at
> EnterpriseDB) are mostly uses English as our base language.
>
> Can you please share the changes with us?
> Or, please publish your repository on github.
>
>>
>> 1. Currently the encoding is hard-set to utf8, we changed it to latin9.
>> 2. Have a type of user that cant register/delete servers/databases. They
>> should see a predefined list that they cannot modify, additionally we
>> modified pgadmin so these users cant drop/create databases/users, etc.
>>
> 3. Add a comment to the top of all outgoing queries performed by pg admin
>> so postgres logs what pgadmin user performed the action - this is super
>> useful because this way we dont need to add postgres users to all the
>> servers, the comment is something like -- PGADMIN : $USERNAME --
>>
>> 4. I feel like the connection reutlization thing is kinda flaky, We get a
>> lot of "prerequisite error" stuff in the browser, we deal with it by
>> refreshing the browser.
>> 5. Add support for having some other caching server ( nginx ) in front
>> of apache. We were able to get this to work with a bunch of rewrite/retry
>> cfg in nginx, but it was tricky.
>>
>
>> pgadmin4 is awesome - we love it! great work
>>
>
> Your changes may help us understand us the problem in real world.
>
> Let's make it better together!
>
> --
> Thanks & Regards,
>
> Ashesh Vashi
>
>>
>> On Fri, Feb 24, 2017 at 1:08 PM, Anthony DeBarros <adebarros(at)gmail(dot)com>
>> wrote:
>>
>>> I'd be very interested in contributing, but my days are pretty consumed
>>> with my day job. Let me know what kind of flexibility you have.
>>>
>>> On Fri, Feb 24, 2017 at 2:50 PM, Shirley Wang <swang(at)pivotal(dot)io> wrote:
>>>
>>>> It'll be a 1 on 1 conversation. We're avoiding webinar type
>>>> presentations so we can get your feedback directly without bias.
>>>>
>>>> I'm sending you another email directly to figure out details now!
>>>>
>>>> On Fri, Feb 24, 2017 at 2:38 PM Adam Brusselback <
>>>> adambrusselback(at)gmail(dot)com> wrote:
>>>>
>>>>> Hi Shirley,
>>>>>
>>>>> The conversation will take about an hour, although if you have time
>>>>> constraints but would still like to chat, let us know and we can
>>>>> accommodate. If you're interested, please respond to this thread with some
>>>>> dates and times and we'll follow up shortly.
>>>>>
>>>>> Just wondering, are you planning on doing a webinar type presentation
>>>>> while asking for feedback while it's going (so you can show a bunch of
>>>>> people at once)? Or are you planning on doing 1 on 1 conversations?
>>>>>
>>>>> I'd be interested, either way. I don't have anything blocked out on
>>>>> my calendar for Monday, Tuesday, or Wednesday of next week.
>>>>>
>>>>> Thanks,
>>>>> -Adam
>>>>>
>>>>
>>>
>>
>