| From: | George Gelashvili <ggelashvili(at)pivotal(dot)io> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: connection error |
| Date: | 2017-02-16 16:31:49 |
| Message-ID: | CAHowoHZo60UKPS8wBXXxU=bXkw2ryj0oUD8QEXZ4wZRQWpGUkQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
aaaand here's a patch
On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili <ggelashvili(at)pivotal(dot)io>
wrote:
> Hi Hackers!
>
> Our tests found a bug with the current version of master, that was
> introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
> It is throwing an error when the server starts up and returns an error
> message of None, and thereby breaking the happy path. There is a function
> ('create' around line 587) in servers/__init__.py that checks against the
> attribute 'decode', which the server doesn't have when there isn't an error
> message.
>
> George & Sarah
>
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fixes-bug-with-connecting-to-server.patch | application/octet-stream | 1.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dave Page | 2017-02-16 16:42:24 | pgAdmin 4 commit: Don't try to decode connection error strings that are |
| Previous Message | George Gelashvili | 2017-02-16 16:26:24 | connection error |