From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | George Gelashvili <ggelashvili(at)pivotal(dot)io> |
Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
Subject: | Re: connection error |
Date: | 2017-02-16 16:42:29 |
Message-ID: | CA+OCxowxRCexo5-GVJb5xqzkJHaWgBtcoSszvhYuek+B+wTASw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
Thanks, applied.
On Thu, Feb 16, 2017 at 4:31 PM, George Gelashvili
<ggelashvili(at)pivotal(dot)io> wrote:
> aaaand here's a patch
>
> On Thu, Feb 16, 2017 at 11:26 AM, George Gelashvili <ggelashvili(at)pivotal(dot)io>
> wrote:
>>
>> Hi Hackers!
>>
>> Our tests found a bug with the current version of master, that was
>> introduced by the commit 9ad1316990cf54da665546ad2dff367557b98262.
>> It is throwing an error when the server starts up and returns an error
>> message of None, and thereby breaking the happy path. There is a function
>> ('create' around line 587) in servers/__init__.py that checks against the
>> attribute 'decode', which the server doesn't have when there isn't an error
>> message.
>>
>> George & Sarah
>
>
>
>
> --
> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Shirley Wang | 2017-02-16 17:19:03 | Re: Autoformatting |
Previous Message | Dave Page | 2017-02-16 16:42:24 | pgAdmin 4 commit: Don't try to decode connection error strings that are |