[patch] We can see tables in Greenplum!

From: George Gelashvili <ggelashvili(at)pivotal(dot)io>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: [patch] We can see tables in Greenplum!
Date: 2017-02-08 15:56:01
Message-ID: CAHowoHYA3_yxFuPYGGcTum5CiJzoZKJV3rgrFPYaw9MgXN4GNA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello Hackers!

We've a fix for displaying table nodes when connected to Greenplum. The
salient bit was leaving off tgisinternal from the default template (but
leaving the template used for postgres 9.1+ unchanged).
We also added a Database helper class in test_utils for setting up and
tearing down a database. It can be used via python's with (see
TestTablesNode).

This isn't super important, but does anyone know why our test comment
doesn't show up in test output?

We see:

> runTest
> (pgadmin.browser.server_groups.servers.databases.schemas.tables.templates.table.sql.tests.test_tables_node.TestTablesNode)
> ... {'oid': 106072, 'has_enable_triggers': '0', 'name': 'test_table',
> 'triggercount': '0'}

Whereas for other tests we see output like

> This function update the server details (Default Server Node url)

Cheers!
Tira & George

Attachment Content-Type Size
fix-greenplum-show-tables.diff text/plain 7.4 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-02-08 16:28:09 pgAdmin 4 commit: Python 2.6 compatibility fixes.
Previous Message Dave Page 2017-02-08 11:40:47 pgAdmin 4 commit: Fix indentation