| From: | Catalin Iacob <iacobcatalin(at)gmail(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: PL/Pythonu - function ereport |
| Date: | 2016-03-01 17:48:07 |
| Message-ID: | CAHg_5griURp72Z-zO-yaxsJRsNJiOTc5_LxaMzkFQGL1H7xKXQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/1/16, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
>> I though about it before and I prefer variant with possibility to enter
>> message as keyword parameter.
That's also ok, but indeed with a check that it's not specified twice
which I see you already added.
> I merged your patches without @3 (many thanks for it). Instead @3 I
> disallow double message specification (+regress test)
Great, welcome. Ran the tests for plpython-enhanced-error-06 again on
2.4 - 2.7 and 3.5 versions and they passed.
I see the pfree you added isn't allowed on a NULL pointer but as far
as I see message is guaranteed not to be NULL as dgettext never
returns NULL.
I'll mark this Ready for Committer.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2016-03-01 18:01:58 | Re: [NOVICE] WHERE clause not used when index is used |
| Previous Message | Tom Lane | 2016-03-01 17:37:23 | Re: [NOVICE] WHERE clause not used when index is used |