| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Catalin Iacob <iacobcatalin(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: proposal: PL/Pythonu - function ereport |
| Date: | 2016-03-02 05:01:13 |
| Message-ID: | CAFj8pRDk9z4F7D6fG9TtpG3LVfq0CVosPHroC2g_uLrF==a_vQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi
2016-03-01 18:48 GMT+01:00 Catalin Iacob <iacobcatalin(at)gmail(dot)com>:
> On 3/1/16, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:
> >> I though about it before and I prefer variant with possibility to enter
> >> message as keyword parameter.
>
> That's also ok, but indeed with a check that it's not specified twice
> which I see you already added.
>
> > I merged your patches without @3 (many thanks for it). Instead @3 I
> > disallow double message specification (+regress test)
>
> Great, welcome. Ran the tests for plpython-enhanced-error-06 again on
> 2.4 - 2.7 and 3.5 versions and they passed.
>
> I see the pfree you added isn't allowed on a NULL pointer but as far
> as I see message is guaranteed not to be NULL as dgettext never
> returns NULL.
>
> I'll mark this Ready for Committer.
>
Thank you very much
Nice day
Pavel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2016-03-02 05:01:32 | Re: Relation extension scalability |
| Previous Message | Michael Paquier | 2016-03-02 04:49:27 | Re: TAP / recovery-test fs-level backups, psql enhancements etc |