Re: [BUG] Fix DETACH with FK pointing to a partitioned table fails

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> 于2024年8月8日周四 06:50写道：

> On 2024-Jul-26, Tender Wang wrote:
>
> > Junwang Zhao <zhjwpku(at)gmail(dot)com> 于2024年7月26日周五 14:57写道：
> >
> > > There is a bug report[0] Tender comments might be the same issue as
> > > this one, but I tried Alvaro's and mine patch, neither could solve
> > > that problem, I did not tried Tender's earlier patch thought. I post
> > > the test script below in case you are interested.
> >
> > My earlier patch should handle Alexander reported case. But I did not
> > do more test. I'm not sure that wether or not has dismatching between
> > pg_constraint and pg_trigger.
> >
> > I aggred with Alvaro said that "requires a much more invasive
> > solution".
>
> Here's the patch which, as far as I can tell, fixes all the reported
> problems (other than the one in bug 18541, for which I proposed an
> unrelated fix in that thread[1]). If you can double-check, I would very
> much appreciate that. Also, I think the test cases the patch adds
> reflect the provided examples sufficiently, but if we're still failing
> to cover some, please let me know.
>
>
> As I understand, this fix needs to be applied all the way back to 12,
> because the overall functionality is that old. However, in branches 14
> and back, the patch doesn't apply cleanly, because of the changes we
> made in commit f4566345cf40 :-( I'm tempted to fix it in branches 15,
> 16, 17, master now and potentially backpatch later, to avoid dragging
> things along further. It's taken long enough already.
>

I haven't seen this patch on master. Is there something that we fotget to
handle?

--
Tender Wang