From: | Tender Wang <tndrwang(at)gmail(dot)com> |
---|---|
To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Richard Guo <guofenglinux(at)gmail(dot)com> |
Subject: | Re: "type with xxxx does not exist" when doing ExecMemoize() |
Date: | 2024-03-11 05:31:26 |
Message-ID: | CAHewXNmYkE7syLaD20PD4N999kWni-wi=pcxL6vdKe=bxkw-=w@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
David Rowley <dgrowleyml(at)gmail(dot)com> 于2024年3月11日周一 13:25写道:
> On Thu, 7 Mar 2024 at 22:50, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> >
> > On Thu, 7 Mar 2024 at 15:24, Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> > >
> > > Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> 于2024年3月6日周三 11:37写道:
> > >> I think, it is a bug. Should it be fixed (and back-patched) earlier?
> > >
> > > Agreed. Need David to review it as he knows this area best.
> >
> > This is on my list of things to do. Just not at the top yet.
>
> I've gone over this patch and I'm happy with the changes to
> nodeMemoize.c. The thing I did change was the newly added test. The
> problem there was the test was passing for me with and without the
> code fix. I ended up changing the test so the cache hits and misses
> are reported. That required moving the test to above where the
> work_mem is set to 64KB so we can be certain the values will all be
> cached and the cache hits are predictable.
>
> My other changes were just cosmetic.
>
> Thanks for working on this fix. I've pushed the patch.
>
> David
>
Thanks for pushing the patch.
--
Tender Wang
OpenPie: https://en.openpie.com/
From | Date | Subject | |
---|---|---|---|
Next Message | Alexey Ermakov | 2024-03-11 08:12:57 | Re: BUG #18349: ERROR: invalid DSA memory alloc request size 1811939328, CONTEXT: parallel worker |
Previous Message | David Rowley | 2024-03-11 05:25:43 | Re: "type with xxxx does not exist" when doing ExecMemoize() |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-03-11 05:46:17 | Re: Add new error_action COPY ON_ERROR "log" |
Previous Message | David Rowley | 2024-03-11 05:25:43 | Re: "type with xxxx does not exist" when doing ExecMemoize() |