Re: "type with xxxx does not exist" when doing ExecMemoize()

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Tender Wang <tndrwang(at)gmail(dot)com>
Cc: Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>, Richard Guo <guofenglinux(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: "type with xxxx does not exist" when doing ExecMemoize()
Date: 2024-03-11 05:25:43
Message-ID: CAApHDvr3X_zDXyQsWn1dtFL9i0bx3jaU1chNhjuqic8eKDC4_w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Thu, 7 Mar 2024 at 22:50, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
> On Thu, 7 Mar 2024 at 15:24, Tender Wang <tndrwang(at)gmail(dot)com> wrote:
> >
> > Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> 于2024年3月6日周三 11:37写道:
> >> I think, it is a bug. Should it be fixed (and back-patched) earlier?
> >
> > Agreed. Need David to review it as he knows this area best.
>
> This is on my list of things to do. Just not at the top yet.

I've gone over this patch and I'm happy with the changes to
nodeMemoize.c. The thing I did change was the newly added test. The
problem there was the test was passing for me with and without the
code fix. I ended up changing the test so the cache hits and misses
are reported. That required moving the test to above where the
work_mem is set to 64KB so we can be certain the values will all be
cached and the cache hits are predictable.

My other changes were just cosmetic.

Thanks for working on this fix. I've pushed the patch.

David

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tender Wang 2024-03-11 05:31:26 Re: "type with xxxx does not exist" when doing ExecMemoize()
Previous Message Tomas Vondra 2024-03-10 20:43:11 Re: Undetected deadlock between client backend and startup processes on a standby (Previously, Undetected deadlock between primary and standby processes)

Browse pgsql-hackers by date

  From Date Subject
Next Message Tender Wang 2024-03-11 05:31:26 Re: "type with xxxx does not exist" when doing ExecMemoize()
Previous Message Andrei Lepikhov 2024-03-11 05:13:02 Re: POC, WIP: OR-clause support for indexes