Re: BUG #18568: BUG: Result wrong when do group by on partition table!

From: Tender Wang <tndrwang(at)gmail(dot)com>
To: 狂奔的蜗牛 <1105066510(at)qq(dot)com>
Cc: pgsql-bugs <pgsql-bugs(at)lists(dot)postgresql(dot)org>
Subject: Re: BUG #18568: BUG: Result wrong when do group by on partition table!
Date: 2024-08-06 14:37:56
Message-ID: CAHewXNkJusO0T1fWbWUN7-DV97bFExOnqSK1VuHx77rCL6d4UQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

狂奔的蜗牛 <1105066510(at)qq(dot)com> 于2024年8月6日周二 19:33写道:

> Partkey's collation stored in RelOptInfo->part_scheme, and I use it to fix
> the bug.
> The attachment is my solution!
>

I look through your patch. Some code is not native for PG. For example:

if (nodeTag(groupexpr) == T_RelabelType)

usually, we use IsA() func.

--
Tender Wang

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2024-08-06 14:38:38 Re: BUG #18570: Drop event trigger for DDL finishes successfully but trigger still executed on DDL
Previous Message Tender Wang 2024-08-06 13:23:44 Re: BUG #18568: BUG: Result wrong when do group by on partition table!