Re: BUG #18712: inet value ::2 handling goes not as expected

вс, 17 нояб. 2024 г. в 20:05, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>:

> PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> > I think that statement
> > select '::0.0.0.2'::inet;
> > should return '::0.0.0.2' value, not '::2'
>
> > I think this is what was intended in the Postgres sources. But it seems
> that
> > this line is never executed:
> >
> https://github.com/postgres/postgres/blob/7b88529f4363994450bd4cd3c172006a8a77e222/src/port/inet_net_ntop.c#L260
>
> Hmm ... you are right that that code doesn't do what it seems to
> intend to, because by the time that we get to this logic we have
> i == 7 not i == 6.

Yes, this code block should be placed at first place inside of for loop

> But I'm not sure if we should change it after
> all this time. We're about as likely to get complaints as kudos,
> I fear. And the output isn't incorrect, just not-per-style.
>
> I wonder whether ISC ever changed their version?
>

https://github.com/openbsd/src/blob/f7304f605db8e3a4de0a0d1c1488830678f77517/sys/netinet/inet_ntop.c#L196
Looks, they don't used 0x0001 check, so, they version was always as intended