Re: BUG #18712: inet value ::2 handling goes not as expected

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: denis(dot)feklushkin(at)gmail(dot)com
Cc: pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: BUG #18712: inet value ::2 handling goes not as expected
Date: 2024-11-17 17:05:11
Message-ID: 3065772.1731863111@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

PG Bug reporting form <noreply(at)postgresql(dot)org> writes:
> I think that statement
> select '::0.0.0.2'::inet;
> should return '::0.0.0.2' value, not '::2'

> I think this is what was intended in the Postgres sources. But it seems that
> this line is never executed:
> https://github.com/postgres/postgres/blob/7b88529f4363994450bd4cd3c172006a8a77e222/src/port/inet_net_ntop.c#L260

Hmm ... you are right that that code doesn't do what it seems to
intend to, because by the time that we get to this logic we have
i == 7 not i == 6. But I'm not sure if we should change it after
all this time. We're about as likely to get complaints as kudos,
I fear. And the output isn't incorrect, just not-per-style.

I wonder whether ISC ever changed their version?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2024-11-17 17:22:44 Re: BUG #18708: regex problem: (?:[^\d\D]){0} asserts with "lp->nouts == 0 && rp->nins == 0"
Previous Message Noah Misch 2024-11-17 16:12:10 Re: BUG #18708: regex problem: (?:[^\d\D]){0} asserts with "lp->nouts == 0 && rp->nins == 0"