From: | Christopher BROWN <brown(at)reflexe(dot)fr> |
---|---|
To: | Dave Cramer <pg(at)fastcrypt(dot)com> |
Cc: | Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Dang Minh Huong <kakalot49(at)gmail(dot)com>, "pgsql-jdbc(at)postgresql(dot)org" <pgsql-jdbc(at)postgresql(dot)org> |
Subject: | Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; " |
Date: | 2015-10-07 12:42:33 |
Message-ID: | CAHL_zcOUvRFBAttQSnRiOPqk8RFocq-dCMO3FOyrJ1OUZyQh-Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-jdbc |
Hello,
Developers that use the driver via a framework (open-source, in-house)
might not be in a position to change SQL, compared with developers that are
able to modify hand-written SQL, so it's probably best to tolerate it by
discarding any trailing semi-colon (with or without any trailing
whitespace) in the parser.
I've also encountered coding practices (coding-style "standards") where
semi-colons are expected (some people just love terminating all statements,
not just Java, with semi-colons, even when it's not strictly necessary
(e.g.: JavaScript).
So, my preference would be to maintain backwards-compatibility for others,
even if I don't have such an issue myself.
--
Christopher
On 7 October 2015 at 14:34, Dave Cramer <pg(at)fastcrypt(dot)com> wrote:
> This is a very good question, but lots of people cut and paste SQL into
> code ... sometimes the ; gets in there.
>
> Behaviour of previous version is important, but in this case It may not be
> justified.
>
> Anyone else have an opinion ?
>
> Dave Cramer
>
> dave.cramer(at)credativ(dot)ca
> http://www.credativ.ca
>
> On 7 October 2015 at 08:30, Vladimir Sitnikov <sitnikov(dot)vladimir(at)gmail(dot)com
> > wrote:
>
>> I wonder why pgjdbc would want to silently ignore that user error?
>> Is "behavior of previous version" a sole justification?
>>
>> I've drafted https://github.com/pgjdbc/pgjdbc/pull/386 to cover that.
>>
>> Vladimir
>>
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Leonardo Frittelli | 2015-10-07 16:33:19 | Connection terminated by the server causes deadlock in jdbc client side connection |
Previous Message | Dave Cramer | 2015-10-07 12:34:19 | Re: JDBC-94: "Multiple resultsets were returned by query" in query end with "; " |