Re: pgsql: docs: Improve documentation of \pset without arguments.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: docs: Improve documentation of \pset without arguments.
Date: 2014-08-11 03:14:22
Message-ID: CAHGQGwHcqqznc2RN3RUX3Hw=fp0DDdwvQB2TJSbvZUq3bAv5tw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Aug 11, 2014 at 6:34 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Sun, Aug 10, 2014 at 12:55 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>> On Thu, Jul 24, 2014 at 9:12 PM, Robert Haas <rhaas(at)postgresql(dot)org> wrote:
>>> docs: Improve documentation of \pset without arguments.
>>>
>>> The syntax summary previously failed to clarify that the first
>>> argument is also optional. The textual description did mention it,
>>> but all the way at the bottom. It fits better with the command
>>> overview, so move it there, and fix the summary also.
>>
>> Is it better to back-patch this to 9.4? The first argument of
>> \pset command is optional also in 9.4.
>
> I didn't feel it necessary, but if you want to, it's OK with me.

Yes, I'm inclined to back-patch that. Because the current description
of the syntax of \pset in 9.4 is not correct.

>> This commit is in next CF with "Ready for Committer".
>> Probably it needs to be marked as "Committed".
>
> Done.

Thanks.

Regards,

--
Fujii Masao

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David G Johnston 2014-08-11 03:39:27 Re: pgsql: Further cleanup of JSON-specific error messages.
Previous Message Robert Haas 2014-08-10 21:34:27 Re: pgsql: docs: Improve documentation of \pset without arguments.