| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add hooks for session start and session end, take two |
| Date: | 2019-10-02 04:27:50 |
| Message-ID: | CAHGQGwGy7Dg95YXppzRqiX-q=y5mePKSS8YjX13CMHe9h0WbWQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Oct 2, 2019 at 9:26 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Tue, Oct 01, 2019 at 05:02:28PM -0700, Andres Freund wrote:
> > The reason for that is simply that at that point llvmjit.c's own
> > shutdown hook has already shutdown parts of the JIT subsystem (which
> > needs to flush profiling information to disk, for profiling to be
> > useful).
>
> Hmm. I missed the actual point. The current location for the session
> end hook has been chosen because we are sure that any transaction has
> been aborted properly, and we'd still be limited with a hook in
> proc_exit_prepare() because of that same argument. I am just going to
> revert the patch.
If only session end hook is problematic, you will commit session start
hook again?
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-10-02 05:14:24 | Re: pgsql: Add hooks for session start and session end, take two |
| Previous Message | Michael Paquier | 2019-10-02 01:13:43 | pgsql: Revert hooks for session start and end, take two |