Re: pgsql: Add hooks for session start and session end, take two

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Date: 2019-10-02 00:25:58
Message-ID: 20191002002558.GB3130@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Oct 01, 2019 at 05:02:28PM -0700, Andres Freund wrote:
> The reason for that is simply that at that point llvmjit.c's own
> shutdown hook has already shutdown parts of the JIT subsystem (which
> needs to flush profiling information to disk, for profiling to be
> useful).

Hmm. I missed the actual point. The current location for the session
end hook has been chosen because we are sure that any transaction has
been aborted properly, and we'd still be limited with a hook in
proc_exit_prepare() because of that same argument. I am just going to
revert the patch.
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2019-10-02 01:13:43 pgsql: Revert hooks for session start and end, take two
Previous Message Andres Freund 2019-10-02 00:02:28 Re: pgsql: Add hooks for session start and session end, take two