Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.

From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Make fast promotion the default promotion mode.
Date: 2013-05-02 06:58:29
Message-ID: CAHGQGwGX7P+mt7imQDPz75NJYH-ZoFePo1ef33opi=v2--1vHA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Thu, May 2, 2013 at 9:25 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Wed, May 1, 2013 at 07:23:33PM -0400, Robert Haas wrote:
>> On Wed, May 1, 2013 at 12:10 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> > Heikki said "...remove pg_ctl -m fast/smart option altogether. There
>> > is no need to expose that to users."
>> >
>> > So it is no longer exposed to users. If there are others that share
>> > that opinion we may change this.
>>
>> /me blinks.
>>
>> I'm not sure we truly need two types of promotion. But if we do, it
>> makes no sense to me to have it and not allow users to select the one
>> they want.
>
> I am also confused why we would have two promotion modes. Either the
> default mode works, or it doesn't, and we fix it. If there is enough
> concern that fast promotion will not work, should we remove that
> ability?

I don't have any other reason than that fast promotion is less stable.
I agree that we should spend the time testing the feature rather than
adding the workaround in this case.

Regards,

--
Fujii Masao

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2013-05-02 14:27:41 pgsql: pg_test_fsync: update output to show usecs/op clearer
Previous Message KONDO Mitsumasa 2013-05-02 04:39:28 Re: pgsql: Install recycled WAL segments with current timeline ID during re

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2013-05-02 07:31:03 Re: Recovery target 'immediate'
Previous Message Simon Riggs 2013-05-02 06:55:18 Re: Recovery target 'immediate'