Re: pgsql: doc: Further clarify how recovery target parameters are applied

On Mon, Sep 30, 2019 at 10:14 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Mon, Sep 30, 2019 at 6:10 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> >
> > doc: Further clarify how recovery target parameters are applied
> >
> > Recovery target parameters are all applied even in standby mode. The
> > previous documentation mostly wished they were not but this was never
> > the case.
>
> Thanks for improving the documentation.
>
> + In this mode, the parameters from both this section and <xref
> + linkend="runtime-config-wal-recovery-target"/> will be used. Parameters
> + from <xref linkend="runtime-config-replication-standby"/> will not be
> + used.
>
> The latter description seems not true. hot_standby and
> max_standby_archive_delay in "runtime-config-replication-standby"
> are used during archive recovery. So something like the following
> change would need to be applied, I think. Patch attached.
>
> In this mode, the parameters from both this section and <xref
> linkend="runtime-config-wal-recovery-target"/> will be used. Parameters
> from <xref linkend="runtime-config-replication-standby"/> will not be
> - used.
> + used (<varname>hot_standby</varname> and
> + <varname>max_standby_archive_delay</varname>).
> </para>

In the above change, I forgot to add "except" before "<varname>hot_standby"...

Now, not only hot_standby and max_standby_archive_delay but also
recovery_min_apply_delay from
<xref linkend="runtime-config-replication-standby"/> can be used in
archive recovery, thanks to commit ec1259e880. So I'm just inclined to
remove the description "Parameters from
<xref linkend="runtime-config-replication-standby"/> will not be used."
rather than to list all "exceptive" parameters.

Regards,

--
Fujii Masao