| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Support for REINDEX CONCURRENTLY |
| Date: | 2013-03-05 14:22:14 |
| Message-ID: | CAHGQGwENdAPn1PYnrgf5q1a_xrUbZ6zrLP7EBrOGw=Jf3zaMAA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 5, 2013 at 10:35 PM, Michael Paquier
<michael(dot)paquier(at)gmail(dot)com> wrote:
> Thanks for the review. All your comments are addressed and updated patches
> are attached.
I got the compile warnings:
tuptoaster.c:1539: warning: format '%s' expects type 'char *', but
argument 3 has type 'Oid'
tuptoaster.c:1539: warning: too many arguments for format
The patch doesn't handle the index on the materialized view correctly.
=# CREATE TABLE hoge (i int);
CREATE TABLE
=# CREATE MATERIALIZED VIEW hogeview AS SELECT * FROM hoge;
SELECT 0
=# CREATE INDEX hogeview_idx ON hogeview(i);
CREATE INDEX
=# REINDEX TABLE hogeview;
REINDEX
=# REINDEX TABLE CONCURRENTLY hogeview;
NOTICE: table "hogeview" has no indexes
REINDEX
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-03-05 14:32:41 | Re: [GENERAL] Floating point error |
| Previous Message | Dean Rasheed | 2013-03-05 14:21:40 | Re: Re: proposal: a width specification for s specifier (format function), fix behave when positional and ordered placeholders are used |