| From: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com> |
| Subject: | Re: Support for REINDEX CONCURRENTLY |
| Date: | 2013-03-06 00:07:03 |
| Message-ID: | CAB7nPqShC7nYG3USBbhwNcXD8vu6UD6K5MODJSoVUtidEifwnQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Mar 5, 2013 at 11:22 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Tue, Mar 5, 2013 at 10:35 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
> > Thanks for the review. All your comments are addressed and updated
> patches
> > are attached.
>
> I got the compile warnings:
> tuptoaster.c:1539: warning: format '%s' expects type 'char *', but
> argument 3 has type 'Oid'
> tuptoaster.c:1539: warning: too many arguments for format
>
Fixed. Thanks for catching that.
> The patch doesn't handle the index on the materialized view correctly.
>
Hehe... I didn't know that materialized views could have indexes...
I fixed it, will send updated patch once I am done with Andres' comments.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joachim Wieland | 2013-03-06 00:21:45 | Re: Materialized view assertion failure in HEAD |
| Previous Message | Josh Berkus | 2013-03-05 23:36:42 | Re: transforms |