| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: waitpid in pg_basebackup |
| Date: | 2012-07-05 17:43:33 |
| Message-ID: | CAHGQGwE=OMhxE3FFk10_exZ6Mw3TV0xXax6kJiO=JZyvDZ0v1g@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 6, 2012 at 2:01 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> I agree, let's drop the support for waitpid() not being present.
>
> BTW, some digging in the commit logs shows that postmaster.c's
> existing support for using wait3 in place of waitpid was added in
> commit a5494a2d92a2752c610b8b668a7d33478e90c160, "Various patches for
> nextstep by GregorHoffleit". NextStep is presumably quite dead by
> now, and anyway we officially pulled support for it as of 9.2.
>
> I will go ahead and remove that code.
Thanks!
BTW, I was just implementing the patch ;) Patch attached.
Note that I've not tested the patch on Windows environment
because I don't have that....
Regards,
--
Fujii Masao
| Attachment | Content-Type | Size |
|---|---|---|
| drop_ifdef_waitpid_v1.patch | application/octet-stream | 4.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-07-05 18:12:23 | Re: waitpid in pg_basebackup |
| Previous Message | Aidan Van Dyk | 2012-07-05 17:06:50 | Re: Schema version management |