Re: Fix for pageinspect bug in PG 17

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tomas Vondra <tomas(at)vondra(dot)me>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix for pageinspect bug in PG 17
Date: 2024-11-14 00:54:03
Message-ID: CAH2-WzniX+CJWoLGjnPJFfzwYcStGswcv6RTzFcuQoYWxMzvWg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 13, 2024 at 7:48 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Wed, Nov 13, 2024 at 09:00:30PM +0100, Tomas Vondra wrote:
> > Does that mean you think we should fix the issue at hand differently?
> > Say, by looking at number of columns and building the correct tuple,
> > like I did in my initial patch?
>
> 691e8b2e18 is not something I would have done when it comes to
> pageinspect, FWIW. There is the superuser argument for this module,
> so I'd vote for an error and apply the same policy across all branches
> as a matter of consistency.

691e8b2e18 was the one that threw the error?

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2024-11-14 00:55:52 Re: Fix for pageinspect bug in PG 17
Previous Message Michael Paquier 2024-11-14 00:48:12 Re: Fix for pageinspect bug in PG 17