Re: ICU locales and text/char(n) SortSupport on Windows

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ICU locales and text/char(n) SortSupport on Windows
Date: 2017-09-22 16:25:44
Message-ID: CAH2-Wzn78Trk4URWLPudbpEkEMs=Nic+r6j6278ZNdjO+meWRA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 22, 2017 at 7:25 AM, Peter Eisentraut
<peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
> I agree. The attached patch should do it.

I see one small issue here: You'll now need to set ssup->comparator
back to NULL before you return early in the Windows' libc case. That
way, a shim comparator (that goes through bttextcmp(), in the case of
text) will be installed within FinishSortSupportFunction(). Other than
that, looks good to me.

Thanks
--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-09-22 16:46:07 Re: close_ps, NULLs, and DirectFunctionCall
Previous Message Robert Haas 2017-09-22 16:21:29 Re: 10RC1 crash testing MultiXact oddity