Re: close_ps, NULLs, and DirectFunctionCall

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: close_ps, NULLs, and DirectFunctionCall
Date: 2017-09-22 16:46:07
Message-ID: CA+TgmobrSXOSUtjpAQ=p3M0SN3s0gaMiF23=fRb54e2UFWC4TQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 20, 2017 at 4:25 PM, Andrew Gierth
<andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
> postgres=# select point(1,2) ## '((0,0),(NaN,NaN))'::box;
> ERROR: function 0x9c5de0 returned NULL
>
> postgres=# select point(1,2) <-> '((0,0),(NaN,NaN))'::box;
> ERROR: function 0x9c5de0 returned NULL
>
> This seems ... unhelpful (though it's at least better than crashing) and
> inconsistent.

I'd call that a bug.

> The most consistent fix would seem
> to be to make all the affected functions return NULL,

Based on your description of the problem I would tend to agree,
although I'm not really familiar with this area.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Melanie Plageman 2017-09-22 16:57:07 Re: [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.
Previous Message Peter Geoghegan 2017-09-22 16:25:44 Re: ICU locales and text/char(n) SortSupport on Windows