Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output
Date: 2021-12-11 21:13:56
Message-ID: CAH2-Wzkqta=bACjSFq5BEGqaBJakWTr2pJcjVUpE22D0jnDN4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 11, 2021 at 12:24 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> But the ereport is inside an if (verbose), no?

Yes -- in order to report aggressiveness in VACUUM VERBOSE. But the
autovacuum case still reports verbose-ness, in the same way as it
always has -- in that same LOG entry. We don't want to repeat
ourselves in the VERBOSE case, which will have already indicated its
verboseness in the up-front ereport().

In other words, every distinct case reports on its aggressiveness
exactly once per call into lazyvacuum.c. In roughly the same way as it
works on HEAD.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2021-12-11 21:16:39 Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output
Previous Message Andres Freund 2021-12-11 20:24:44 Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output