Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output
Date: 2021-12-11 22:51:58
Message-ID: 20211211225158.utbyfnfgmvnwn557@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2021-12-11 13:13:56 -0800, Peter Geoghegan wrote:
> On Sat, Dec 11, 2021 at 12:24 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > But the ereport is inside an if (verbose), no?
>
> Yes -- in order to report aggressiveness in VACUUM VERBOSE. But the
> autovacuum case still reports verbose-ness, in the same way as it
> always has -- in that same LOG entry. We don't want to repeat
> ourselves in the VERBOSE case, which will have already indicated its
> verboseness in the up-front ereport().

I feel one, or both, must be missing something here. My point was that you
said upthread that the patch doesn't change DEBUG2/non-verbose logging for
most messages. But the fact that those messages are only emitted inside and if
(verbose) seems to contradict that?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2021-12-11 23:11:42 Re: Unifying VACUUM VERBOSE and log_autovacuum_min_duration output
Previous Message Justin Pryzby 2021-12-11 22:43:08 Re: pg_upgrade failing for 200+ million Large Objects