Re: amcheck packages

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Christoph Berg <myon(at)debian(dot)org>, Peter Geoghegan <pg(at)bowt(dot)ie>, pgsql-pkg-debian(at)postgresql(dot)org
Subject: Re: amcheck packages
Date: 2017-10-07 20:33:08
Message-ID: CAH2-WzkqW2K9Pkbi_erkjQV3iFxjgKu3sKYQieKA68hixtqM4A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-pkg-debian

On Sat, Oct 7, 2017 at 1:10 PM, Christoph Berg <myon(at)debian(dot)org> wrote:
> I could download the tarball now and build packages. I've already
> built them for apt.pg.o, and promoted them to the *-pgdg
> distributions, they will appear on the mirrors in about half an hour.
>
> For Debian, I made two small changes:
>
> --- a/debian/changelog
> +++ b/debian/changelog
> -amcheck (1.0-1) stable; urgency=medium
> +amcheck (1.0-1) unstable; urgency=medium
>
> --- a/debian/control.in
> +++ b/debian/control.in
> -Standards-Version: 3.9.6
> +Standards-Version: 4.1.1
>
> Maybe you could apply that, and possibly bump up the debian/1.0-1 tag
> to reflect it (but that doesn't really matter much).

Note that "debian/watch" is grabbing tags that match "v(.*).tar.gz".
So, even though I use "debian*" tags, too, I'm not sure that bumping
the tag will work for us. It might be easier to make the changes you
ask for formally "v1.1" and "debian/1.1-1" (i.e. avoid just bumping up
by creating "debian/1.0-2", which is what you ask for here, I gather).
Please let me know what you think.

I have pushed a branch to Github for this. top commit:

https://github.com/petergeoghegan/amcheck/commit/3b9cc15dbdec1b3864dcf55a4de5492c7244cd47

(That creates a v1.1 for this reason, which might well be overkill.)

> Is debian/pgversions intentionally not "9.4+"? We usually only list
> explicit maximum versions if the newer versions are not supported on
> purpose, and don't just "not work yet". (Though if the repo hosts both
> upstream and debian/, that's probably ok.)

I decided that that wasn't a good idea, because the build is likely to
break for silly reasons. But, that that's true is hardly unique to
amcheck, and it actually targets what seem to be very stable
interfaces. If that's actually the defacto standard (try it and see),
I will change back on the branch that's up for review from you.

--
Peter Geoghegan

In response to

Responses

Browse pgsql-pkg-debian by date

  From Date Subject
Next Message Peter Geoghegan 2017-10-07 20:37:56 Re: amcheck packages
Previous Message Christoph Berg 2017-10-07 20:10:06 Re: amcheck packages