Re: amcheck packages

From: Christoph Berg <myon(at)debian(dot)org>
To: Peter Geoghegan <pg(at)bowt(dot)ie>
Cc: pgsql-pkg-debian(at)postgresql(dot)org
Subject: Re: amcheck packages
Date: 2017-10-07 20:10:06
Message-ID: 20171007201006.s5n2dr4oej4c7qnr@msg.df7cb.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-pkg-debian

Re: Peter Geoghegan 2017-10-07 <CAH2-Wz=c9OaU_Odiq36Fkht0D9xsshY6_pOtBjt-wM7Mo14Yug(at)mail(dot)gmail(dot)com>
> >> Once this gets your approval, I'll push the commit to the master
> >> branch, and create the appropriate version 1.0 tags. Note that I've
> >> declared version 1.0 as being stable within debian/changelog.

Hi,

sorry I missed that part in the last round - the correct target in
debian/changelog is still "unstable" because that's where all the
uploads go before they trickle into testing and eventually get
released as stable. For apt.pg.o the target distribution doesn't
matter, though.

> The overhead of the tests, which only need to be simple smoke tests,
> is probably totally excessive. I've replaced the tests with the tests
> that actually made it into contrib/amcheck. The amcheck_next tests now
> complete in a couple of seconds, which will greatly reduce the burden
> on your Jenkins installation.

It now worked even on my crammed notebook SSD :)

> I've verified that they pass on all versions myself, and have pushed
> that to the master branch. I've also created release tags
> ("debian/1.0-1", and "v1.0").

I could download the tarball now and build packages. I've already
built them for apt.pg.o, and promoted them to the *-pgdg
distributions, they will appear on the mirrors in about half an hour.

For Debian, I made two small changes:

--- a/debian/changelog
+++ b/debian/changelog
-amcheck (1.0-1) stable; urgency=medium
+amcheck (1.0-1) unstable; urgency=medium

--- a/debian/control.in
+++ b/debian/control.in
-Standards-Version: 3.9.6
+Standards-Version: 4.1.1

Maybe you could apply that, and possibly bump up the debian/1.0-1 tag
to reflect it (but that doesn't really matter much).

Is debian/pgversions intentionally not "9.4+"? We usually only list
explicit maximum versions if the newer versions are not supported on
purpose, and don't just "not work yet". (Though if the repo hosts both
upstream and debian/, that's probably ok.)

Thanks,
Christoph

In response to

Responses

Browse pgsql-pkg-debian by date

  From Date Subject
Next Message Peter Geoghegan 2017-10-07 20:33:08 Re: amcheck packages
Previous Message apt.postgresql.org repository 2017-10-07 19:51:07 amcheck updated to version 1.0-1.pgdg+1