| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Thomas Munro <tmunro(at)postgresql(dot)org>, pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Handle lack of DSM slots in parallel btree build. |
| Date: | 2020-02-04 17:42:12 |
| Message-ID: | CAH2-Wzka0+vyX+iTTug3dKtUPvDDNNpVUY7nTF=MhAFgzTZ3uQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Tue, Feb 4, 2020 at 2:18 AM Thomas Munro <thomas(dot)munro(at)gmail(dot)com> wrote:
> Here is take 2. I tested CI and CIC, and verified that workers are
> started or not depending on dsm_create() failure, using the attached
> fault injector patch. (Fuzzing the regression tests repeatedly with
> that applied also revealed similar problems elsewhere in the tree,
> which I'll write about in a new thread.)
Can we reuse _bt_end_parallel() this time around? It would be easy to
add a "bool wait" argument to _bt_end_parallel(). All existing callers
would pass true, but when not using parallelism due to the new DSM
segment check we'd pass false.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-02-04 17:47:35 | Re: pgsql: Handle lack of DSM slots in parallel btree build. |
| Previous Message | Thomas Munro | 2020-02-04 10:17:24 | Re: pgsql: Handle lack of DSM slots in parallel btree build. |