| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeremy Schneider <schnjere(at)amazon(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XMAX_LOCK_ONLY and XMAX_COMMITTED (fk/multixact code) |
| Date: | 2020-08-28 00:18:04 |
| Message-ID: | CAH2-WzkZUE3T97dtfvPB40Q4w7VyDJ9uLTXpF_Wbn8oaO_VEbA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Aug 27, 2020 at 5:06 PM Mark Dilger
<mark(dot)dilger(at)enterprisedb(dot)com> wrote:
> These two are both checked in verify_heapam.c. The point is that the system will also refuse to write out pages that have this corruption. The Asserts could be converted to panics or whatever, but that has other more serious consequences. Did you have something else in mind?
Oh, I see -- you propose to add both an assert to hio.c, as well as a
check to amcheck itself. That seems like the right thing to do.
Thanks
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2020-08-28 00:22:47 | [PATCH] Explicit null dereferenced (src/backend/access/heap/heaptoast.c) |
| Previous Message | Mark Dilger | 2020-08-28 00:06:23 | Re: XMAX_LOCK_ONLY and XMAX_COMMITTED (fk/multixact code) |