| From: | Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jeremy Schneider <schnjere(at)amazon(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: XMAX_LOCK_ONLY and XMAX_COMMITTED (fk/multixact code) |
| Date: | 2020-08-28 00:06:23 |
| Message-ID: | C5E9D1AC-EB4E-41E7-B97E-255C7CF72799@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Aug 27, 2020, at 4:58 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> On Thu, Aug 27, 2020 at 4:57 PM Mark Dilger
> <mark(dot)dilger(at)enterprisedb(dot)com> wrote:
>> The amcheck patch has Asserts in hio.c that purport to disallow writing invalid header bits to disk.
>
> Can it also be a runtime check for the verification process? I think
> that we can easily afford to be fairly exhaustive about stuff like
> this.
These two are both checked in verify_heapam.c. The point is that the system will also refuse to write out pages that have this corruption. The Asserts could be converted to panics or whatever, but that has other more serious consequences. Did you have something else in mind?
—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2020-08-28 00:18:04 | Re: XMAX_LOCK_ONLY and XMAX_COMMITTED (fk/multixact code) |
| Previous Message | Tom Lane | 2020-08-28 00:00:40 | Re: Clang Address Sanitizer (Postgres14) Detected Memory Leaks |