Re: pgsql: Fix transient mdsync() errors of truncated relations due to 72a9

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: Fix transient mdsync() errors of truncated relations due to 72a9
Date: 2017-09-17 22:22:18
Message-ID: CAH2-Wzk2ou6+L_-SROgsuOBBHe7PUCrXP=afj6ZNWzp7+AV=2w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Wed, May 4, 2016 at 1:59 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> The cleanest fix seems to be to allow the caller of _mdfd_getseg() to
> specify whether checks for RELSEG_SIZE are performed. To allow doing so,
> change the ExtensionBehavior enum into a bitmask. Besides allowing for
> the addition of EXTENSION_DONT_CHECK_SIZE, this makes for a nicer
> implementation of EXTENSION_REALLY_RETURN_NULL.

You missed a remaining reference to EXTENSION_REALLY_RETURN_NULL
within _mdfd_getseg().

--
Peter Geoghegan

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2017-09-18 00:49:06 Re: pgsql: Fix bogus size calculation introduced by commit cc5f81366.
Previous Message Thomas Munro 2017-09-17 21:58:19 Re: pgsql: Fix bogus size calculation introduced by commit cc5f81366.