| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: pgsql: Add more $Test::Builder::Level in the TAP tests |
| Date: | 2021-10-14 04:04:11 |
| Message-ID: | CAH2-Wz=wga3=NJAiQRg0cs-wiqrvkFn6nb4ZPWJwhVV9zWpHRw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Wed, Oct 13, 2021 at 9:00 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> Even for single psql commands in your environment? That would be
> surprising that this does not show the same error about lines 56/57 in
> /home/pg/.psqlrc, but I guess that's up to you for this part..
It's doing this:
-------------------------------------------------
-- Source custom variables from dedicated file --
-------------------------------------------------
\set queries `cat $HOME/dotfiles/psql-rc-queries.sql`
\o /dev/null
:queries -- this is line 56
\gset
I've been doing this for many years now. It's nothing new.
> It does not change the fact that the test needs to be fixed. TAP
> tests should be designed to not be influenced by the external world.
Right.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2021-10-14 16:01:56 | pgsql: Postpone some end-of-recovery operations related to allowing WAL |
| Previous Message | Michael Paquier | 2021-10-14 04:00:30 | Re: pgsql: Add more $Test::Builder::Level in the TAP tests |