| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data |
| Date: | 2021-07-23 22:53:19 |
| Message-ID: | CAH2-Wz=D_3WfFfU4ZgqxMFOsHb_qwqVKD+h_XTSx6yO3V0-m5A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jul 23, 2021 at 3:30 PM Noah Misch <noah(at)leadboat(dot)com> wrote:
> It could be okay, but I think it's better to add the test under amcheck. You
> could still use pgbench in the test.
+1. Writing the test that way seems more robust. If somebody writes a
patch that reintroduces a similar though distinct bug, then it seems
more likely to be caught. In other words, there is less of a danger of
the test over-specifying what incorrect means if it uses amcheck
directly.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-24 21:44:57 | Re: BUG #17122: panic on prepare with subsequent pg_advisory_lock() and pg_advisory_xact_lock_shared() |
| Previous Message | Noah Misch | 2021-07-23 22:30:21 | Re: CREATE INDEX CONCURRENTLY does not index prepared xact's data |