From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Maintaining a list of pgindent commits for "git blame" to ignore |
Date: | 2021-03-18 22:46:10 |
Message-ID: | CAH2-Wz=9A+VyT-Rjou1Pt-1+PshDd+X3s-7Q_GFs7U1nkSHNaA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Thu, Mar 18, 2021 at 3:39 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I don't object to maintaining such a file; if it makes "git blame"
> work better, that's a huge win. However, the file as you have it
> seems rather unreadable. I'd much rather have something that includes
> the commit date and/or first line of commit message. Is there any
> flexibility in the format, or does git blame insist it be just like this?
I ended up doing it that way because I was in a hurry to see how much
it helped. I can fix it up.
We could require (but not automatically enforce) that the first line
of the commit message be included above each hash, as a comment. You
could also require reverse chronological ordering of commits. That
would make everything easy to follow.
It's worth noting that git insists that you provide the full hash of
commits here. This is not something I remember it insisting upon in
any other area. There is probably a very good practical reason for
that.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2021-03-18 23:00:00 | Re: Maintaining a list of pgindent commits for "git blame" to ignore |
Previous Message | Tom Lane | 2021-03-18 22:39:07 | Re: Maintaining a list of pgindent commits for "git blame" to ignore |