| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Rename some rel truncation related constants at the top of vacuumlazy.c |
| Date: | 2022-07-19 04:07:59 |
| Message-ID: | CAH2-Wz=2BDRCrU8+XGGrK1BaJ3Ywez7_Q7st_HG52et_+9p4iA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jul 18, 2022 at 8:55 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Um ... you seem to have removed some useful comments?
I don't think that the stuff about making them into a GUC is useful myself.
> Personally I wouldn't do this, as I don't think the renaming
> brings much benefit, and it will create a hazard for back-patching
> any fixes that might be needed in that code. I'm not hugely upset
> about it, but that's the way I'd vote if asked.
In that case I withdraw the patch.
FWIW I wrote the patch during the course of work on new feature
development. A patch that added a couple of similar constants a bit
further down. Seemed neater this way, but it's certainly not worth
arguing over.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-07-19 04:10:33 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Tom Lane | 2022-07-19 03:55:55 | Re: Rename some rel truncation related constants at the top of vacuumlazy.c |